Fix schema evolution delete test.#338
Merged
teo-tsirpanis merged 1 commit intoTileDB-Inc:mainfrom Dec 11, 2023
Merged
Conversation
|
This pull request has been linked to Shortcut Story #38119: Dropping an attribute seemingly has no effect.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SC-38119
TileDB-Inc/TileDB#4549 fixed array time travelling to honor the starting and ending timestamps when opening the schema.
In the test the array's timestamp had been set by a previous call to
TestUtil.ReadArrayin a range that excluded the remaining attribute.This PR resets the timestamp range before writing the array schema. The test has been verified to be fixed on my machine.
Fixes #334
Fixes #335
Fixes #337